Repository navigation
fix: emit named exports in generated env configs - #20
Merged
Merged
Conversation
Cella's config-builder now imports each environment config by name
(import { development } from './config.development') and config.default
via a named export. generateEnvConfigs still emitted the old
export-default shape, so a fresh scaffold failed its first pnpm generate
with "does not provide an export named 'development'".
Emit export const <mode> with the named _default type import, and add a
regression test asserting the named-export shape for every mode.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh
pnpm create cellajs/cellascaffold fails its firstpnpm generate:Cella's
config-builder/app-config.tsnow imports each environment config by name (import { development } from '../../config/config.development') andconfig.defaultvia the namedconfigexport, butgenerateEnvConfigsstill emitted the oldexport defaultshape withimport type _default from './config.default'.Fix
export const <mode> = { ... }for every environment fileimport type { config as _default } from './config.default'{ development }import in the generated test configTests
export default)pnpm generateruns clean🤖 Generated with Claude Code